move_detect/server/tests/PdoIntegrationTest.php
유창욱 47ab1143e1 feat(fp): operator false-positive tag + per-camera FP-rate report
The feedback loop, per product decision (option a): tags feed STATISTICS only.
A human reads the rate and re-tunes a camera deliberately - the tag never
adjusts edge sensitivity on its own (no silent behavior change in a safety
system).

- POST /events/{id}/false-positive: same RBAC ('acknowledge') + CSRF + site
  scope as ack. Tagging also acknowledges (an FP is a handled event - leaving
  it unacknowledged would keep it alarming). COALESCE keeps the FIRST tagger:
  a second tag never rewrites who made the original audit-relevant call.
- move_events.false_positive_by/at (migration included), audit-logged.
- GET /api/fp-stats?days=N: per-(camera, event_type) totals + FP counts,
  FP>0 groups only, fp-desc, fail-closed site scoping.
- Console: each open row gets a visually-secondary 오탐 button beside 확인
  (can't be fat-fingered as the default); resolved rows show a mono verdict
  ("오탐 (user)" struck through vs "확인됨 (user)"). New rail panel "오탐율 ·
  30일" lists top offenders - 30%+ highlighted as re-tuning candidates -
  refreshed on a slow 60s cadence plus immediately after a tag. Detail view
  shows the tag.

Verified: PHPUnit 135 pass / pytest unchanged + Chrome real-render (tag ->
row flips to struck-through verdict + drops out of unacked KPI/tree counts ->
FP panel updates immediately; no console errors).
2026-08-06 20:38:36 +09:00

189 lines
6.8 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Tests;
use App\Repository\Pdo\{PdoNonceRepository, PdoEventRepository, PdoZoneRepository};
use PDO;
use PHPUnit\Framework\TestCase;
use RuntimeException;
/**
* Gated DB-integration test: exercises the PDO repositories against a real
* sqlite :memory: database instead of the in-memory test doubles used
* elsewhere in the suite. This host has no pdo_sqlite driver loaded
* (PDO::getAvailableDrivers() does not include 'sqlite'), so setUp() skips
* the whole class -- the suite must stay green with this test reported as
* SKIPPED, not failed. On a host with pdo_sqlite available (or in CI), this
* test runs for real and round-trips Nonce, Event, and Zone -- the three
* repositories whose SQL is portable between MySQL and sqlite (no
* MySQL-only `ON DUPLICATE KEY UPDATE`, which PdoRateLimiterRepository uses
* and is therefore intentionally not covered here).
*/
final class PdoIntegrationTest extends TestCase
{
private PDO $pdo;
protected function setUp(): void
{
if (!in_array('sqlite', PDO::getAvailableDrivers(), true)) {
$this->markTestSkipped('pdo_sqlite not available on this host');
}
$this->pdo = new PDO('sqlite::memory:', null, null, [
PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
PDO::ATTR_DEFAULT_FETCH_MODE => PDO::FETCH_ASSOC,
]);
$this->pdo->exec(self::sqliteSchema());
}
public function testNonceRoundTrip(): void
{
$repo = new PdoNonceRepository($this->pdo);
$this->assertFalse($repo->seen('n1'));
$repo->remember('n1', 9999999999);
$this->assertTrue($repo->seen('n1'));
}
public function testEventInsertFindAcknowledge(): void
{
$repo = new PdoEventRepository($this->pdo);
$uuid = str_repeat('a', 32);
$id = $repo->insert([
'event_uuid' => $uuid,
'device_id' => 'dev-1',
'site' => 'factory-a',
'camera_id' => 'cam-1',
'event_type' => 'fall',
'severity' => 'critical',
'track_id' => 7,
'zone_id' => null,
'occurred_at' => 1700000000.5,
'duration_s' => 2.5,
'metrics' => ['confidence' => 0.9],
]);
$this->assertGreaterThan(0, $id);
$found = $repo->find($id);
$this->assertNotNull($found);
$this->assertSame('dev-1', $found['device_id']);
$this->assertSame('factory-a', $found['site']);
$this->assertSame($uuid, $found['event_uuid']);
$this->assertSame('critical', $found['severity']);
$this->assertSame(['confidence' => 0.9], $found['metrics']);
$this->assertNull($found['acknowledged_by']);
// Idempotency key lookup (P1-9).
$this->assertSame($id, $repo->idByUuid($uuid));
$this->assertNull($repo->idByUuid(str_repeat('z', 32)));
// Site-scoped page (P3-2b): matches its own site, excluded from another.
$this->assertCount(1, $repo->page(10, null, null, null, 'factory-a'));
$this->assertCount(0, $repo->page(10, null, null, null, 'factory-b'));
$recent = $repo->recent(10, 'critical');
$this->assertCount(1, $recent);
$this->assertSame([], $repo->recent(10, 'info'));
$this->assertTrue($repo->acknowledge($id, 'alice'));
$this->assertSame('alice', $repo->find($id)['acknowledged_by']);
$this->assertFalse($repo->acknowledge(999999, 'bob'));
}
public function testZoneSaveIsOwnershipScoped(): void
{
$repo = new PdoZoneRepository($this->pdo);
$zoneId = $repo->save([
'zone_id' => null,
'device_id' => 'dev-1',
'camera_id' => 'cam-1',
'level' => 'warning',
'polygon_json' => '[[0,0],[1,0],[1,1]]',
]);
$this->assertNotSame('', $zoneId);
$this->assertCount(1, $repo->forCamera('cam-1'));
// Legitimate update by the owning device/camera succeeds.
$again = $repo->save([
'zone_id' => $zoneId,
'device_id' => 'dev-1',
'camera_id' => 'cam-1',
'level' => 'restricted',
'polygon_json' => '[[0,0],[2,0],[2,2]]',
]);
$this->assertSame($zoneId, $again);
// Supplying the same zone_id under a different device/camera must not
// silently overwrite it -- this is the cross-tenant guard from the
// Task 13 review.
$this->expectException(RuntimeException::class);
$repo->save([
'zone_id' => $zoneId,
'device_id' => 'dev-2',
'camera_id' => 'cam-2',
'level' => 'pinch',
'polygon_json' => '[[9,9],[9,8],[8,8]]',
]);
}
public function testZoneDelete(): void
{
$repo = new PdoZoneRepository($this->pdo);
$zoneId = $repo->save([
'zone_id' => null,
'device_id' => 'dev-1',
'camera_id' => 'cam-1',
'level' => 'warning',
'polygon_json' => '[[0,0],[1,0],[1,1]]',
]);
$this->assertTrue($repo->delete($zoneId));
$this->assertFalse($repo->delete($zoneId));
}
/**
* Minimal sqlite-flavored translation of the nonces/events/zones tables
* in ../schema.sql (see that file's "sqlite compatibility notes" header
* for the general MySQL -> sqlite mapping rules applied here).
*/
private static function sqliteSchema(): string
{
return <<<'SQL'
CREATE TABLE move_nonces (
nonce TEXT PRIMARY KEY,
expires_at INTEGER NOT NULL
);
CREATE TABLE move_events (
event_id INTEGER PRIMARY KEY AUTOINCREMENT,
event_uuid TEXT UNIQUE,
device_id TEXT NOT NULL,
site TEXT,
camera_id TEXT NOT NULL,
event_type TEXT NOT NULL,
severity TEXT NOT NULL,
track_id INTEGER,
zone_id TEXT,
occurred_at REAL NOT NULL,
duration_s REAL NOT NULL DEFAULT 0,
metrics_json TEXT,
spatial_x REAL,
spatial_y REAL,
acknowledged_by TEXT,
acknowledged_at INTEGER,
false_positive_by TEXT,
false_positive_at INTEGER,
received_at INTEGER NOT NULL
);
CREATE TABLE move_zones (
zone_id TEXT PRIMARY KEY,
device_id TEXT NOT NULL,
camera_id TEXT NOT NULL,
level TEXT NOT NULL,
polygon_json TEXT NOT NULL,
rules_json TEXT,
updated_at INTEGER NOT NULL
);
SQL;
}
}